Linaro / Windows: Use LLVM_CCACHE_BUILD instead of CMAKE_CXX_COMPILER_LAUNCHER #464
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LAUNCHER There's nothing wrong with the latter - except that LLVM_CCACHE_BUILD knows that it should not be enabling pre-compiled headers on Windows. See llvm/llvm-project#136856 We had a contributor report an issue with this, and it only got fixed when someone randomly managed to update the right files for an unrelated change. This sounds like a known issue, and if we use LLVM_CCACHE_BUILD, precompiled headers will be disabled. This is fine, our bots weren't relying on this anyway. As far as I could tell we don't customise the ccache install at all either, so the defaults are all fine for us. I've applied this to all 4 Windows bots: clang-arm64-windows-msvc clang-arm64-windows-msvc-2stage flang-arm64-windows-msvc lldb-aarch64-windows The problem is with flang specifically, but we might as well standardise across them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's nothing wrong with the latter - except that LLVM_CCACHE_BUILD knows that it should not be enabling pre-compiled headers on Windows.
See llvm/llvm-project#136856
We had a contributor report an issue with this, and it only got fixed when someone randomly managed to update the right files for an unrelated change.
This sounds like a known issue, and if we use LLVM_CCACHE_BUILD, precompiled headers will be disabled. This is fine, our bots weren't relying on this anyway.
As far as I could tell we don't customise the ccache install at all either, so the defaults are all fine for us.
I've applied this to all 4 Windows bots:
clang-arm64-windows-msvc
clang-arm64-windows-msvc-2stage
flang-arm64-windows-msvc
lldb-aarch64-windows
The problem is with flang specifically, but we might as well standardise across them all.